Repository navigation
sniffles: add forced calling (--genotype-vcf) - #13111
Merged
Merged
Conversation
Generated by Claude
Contributor
Author
|
Hi @awgymer ! Is this what you had in mind for the extended module instead of the new one? |
aksenia
marked this pull request as ready for review
October 9, 2026 06:50
awgymer
reviewed
Oct 9, 2026
Generated by Claude
Contributor
Author
|
@awgymer is this looking good now? I am not sure what is the procedure for replacing a module - is it just to merge? |
awgymer
reviewed
Oct 13, 2026
Contributor
|
Not quite sure what you mean by replace as this is just updating the current module, once I'm happy with the above then I will approve and you can merge as long as the tests are passing |
Provides bgzip in the container.
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
awgymer
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds forced calling (
--genotype-vcf) to the existingsnifflesmodule, as suggested in the review of #13105. Sniffles genotypes a known set of structural variants in the same BAM/CRAM and writes the same--vcfoutput as regular calling, with the known SVs as one additional optional file.genotype_vcfin the first input tuple (tuple val(meta), path(input), path(index), path(genotype_vcf),[]for regular calling) and a--genotype-vcfargument built from it. This changes the input of the module, so callers need to add an empty fourth element.[]; three new tests (gzipped sites VCF, plain sites VCF, stub) use the small HG002 ONT subset and known-SV VCF added in Add HG002 ONT SV genotyping test data test-datasets#2302. The test config uses the calling arguments only when no sites file is given.Replaces #13105.
Generated by Claude
PR checklist
Closes #13106
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda